Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added a x64 guard to the IL2CPP methods #871

Merged
merged 7 commits into from
Jul 6, 2022
Merged

fix: Added a x64 guard to the IL2CPP methods #871

merged 7 commits into from
Jul 6, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jul 6, 2022 •
edited
Loading

There is something off about the way we call native code on x86 so I'm guarding the IL2CPP feature with UNITY_64 for now:

error LNK2019: unresolved external symbol _il2cpp_gchandle_get_target@4 referenced in function _SentryUnityInfo_il2cpp_gchandle_get_target_m42BE043B96499DAF199C1045023BE6DE1B0FF6EA
  Hint on symbols that are defined and could potentially match:
    _il2cpp_gchandle_get_target

This can easily be reproduced with our own samples and throw_cpp.

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner July 6, 2022 12:16
@bitsandfoxes bitsandfoxes changed the title fix: IL2CPP on 64 only fix: Added a x64 guard to the IL2CPP methods Jul 6, 2022
bruno-garcia
bruno-garcia approved these changes Jul 6, 2022
View reviewed changes
package-dev/Runtime/SentryInitialization.cs
@@ -108,7 +108,7 @@ public string Platform

private Il2CppMethods _il2CppMethods
// Lowest supported version to have all required methods below
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER || !UNITY_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a 32 bit Unity build to our CI?

vaind
vaind approved these changes Jul 6, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 93da069 into main Jul 6, 2022
@bitsandfoxes bitsandfoxes deleted the fix/il2cpp-versiongate branch July 6, 2022 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Added a x64 guard to the IL2CPP methods ([#871](https://github.com/getsentry/sentry-unity/pull/871))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d48c53c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitsandfoxes @bruno-garcia @vaind